vangheem commented 4 years ago

Hey @lferran! There is a test failure that I think is fixed by https://github.com/plone/guillotina/pull/841

Could you review maybe?

lferran commented 4 years ago

ouch, it's because my endpoint does not have a permission defined:

     desc += f"permission: {service_def['permission']}"
KeyError: 'permission'

codecov-io commented 4 years ago

Codecov Report

Merging #842 into 5.x will increase coverage by 0.1%. The diff coverage is 100%.

@@           Coverage Diff           @@
##             5.x    #842     +/-   ##
=======================================
+ Coverage   94.4%   94.4%   +0.1%     
=======================================
  Files        306     306             
  Lines      27483   27511     +28     
=======================================
+ Hits       25936   25964     +28     
  Misses      1547    1547

Impacted Files	Coverage Δ
guillotina/test_package.py	`96.7% <100%> (+0.1%)`	:arrow_up:
guillotina/api/service.py	`93.2% <100%> (+0.5%)`	:arrow_up:
guillotina/tests/test_swagger.py	`100% <100%> (ø)`	:arrow_up:

plone / guillotina

[5.x] Fix query params validation for arrays #842

Codecov Report