Closed vangheem closed 4 years ago
Merging #869 into 5.x will decrease coverage by
0.6%
. The diff coverage is61.2%
.
@@ Coverage Diff @@
## 5.x #869 +/- ##
=======================================
- Coverage 94.5% 93.9% -0.5%
=======================================
Files 306 306
Lines 27681 27673 -8
=======================================
- Hits 26131 25972 -159
- Misses 1550 1701 +151
Impacted Files | Coverage Δ | |
---|---|---|
guillotina/db/factory.py | 85.8% <ø> (-7.6%) |
:arrow_down: |
guillotina/db/transaction_manager.py | 91.9% <100%> (+12.5%) |
:arrow_up: |
guillotina/db/storages/pg.py | 88.4% <58.9%> (-0.9%) |
:arrow_down: |
guillotina/tests/test_cockroach.py | 17.7% <0%> (-77.9%) |
:arrow_down: |
guillotina/db/storages/cockroach.py | 27.9% <0%> (-48.1%) |
:arrow_down: |
guillotina/db/strategies/dbresolve.py | 68.5% <0%> (-31.5%) |
:arrow_down: |
guillotina/tests/fixtures.py | 86% <0%> (-7.1%) |
:arrow_down: |
guillotina/tests/test_postgres.py | 99.4% <0%> (-0.6%) |
:arrow_down: |
guillotina/content.py | 92.4% <0%> (-0.3%) |
:arrow_down: |
... and 2 more |
1) expose more pool configuration 2) close should be asyncio task and should never timeout