search

plone / guillotina

Python AsyncIO data API to manage billions of resources
https://guillotina.readthedocs.io/en/latest/
Other
187 stars 51 forks source link

Fix async test without pytest mark #996

Closed masipcat closed 3 years ago

masipcat commented 3 years ago

The test was ignored by pytest.

codecov-commenter commented 3 years ago

Codecov Report

Merging #996 into master will increase coverage by 0.1%. The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #996     +/-   ##
========================================
+ Coverage    94.6%   94.7%   +0.1%     
========================================
  Files         316     316             
  Lines       28049   28049             
========================================
+ Hits        26522   26536     +14     
+ Misses       1527    1513     -14
Impacted Files Coverage Δ
guillotina/tests/test_jsonschema.py 100.0% <100.0%> (+29.1%) :arrow_up:
guillotina/utils/misc.py 80.9% <0.0%> (+2.1%) :arrow_up:
masipcat commented 3 years ago

yeah... i should check the pytest warnings more often... :P

masipcat commented 3 years ago

@vangheem don't merge this please, I want to use this branch to try to find the dependency/versions that's causing the fail

masipcat commented 3 years ago

With pytest-asyncio 0.12.0 works fine. I replayed the jobs twice and both times passed. The problem seems to be with 0.14.0 (https://github.com/pytest-dev/pytest-asyncio/issues/178).

I think we should keep the pin to <=13 to avoid 0.14 until is fixed.

if this sounds good, I think we can merge this pr.