Circular env: always constrain package deps.

[mauritsvanrees]

Otherwise you get the latest packages from PyPI. Currently this means you get plone.app.multilingual 8 which is meant for Plone 6.1, and Products.CMFPlone 6.0.10. These depend on each other so you get an error.

Note that in other places in tox.ini we already use constrain_package_deps = true. But we set this to false when using mxdev. I did not try to understand if that makes sense. But at least for the circular env this would be wrong.

Tested:

• plone.edu (which uses mxdev) depends on plone.app.multilingual and its circular check failed.
• I locally edited plone.app.users to depend on plone.app.multilingual and that one failed as well.

This PR fixes it.

I will let two PRs or comments link to this PR that use it.

[jensens]

mxdev does not care about this setting, all mxdev does is to generate a new constraints and requirements file. So, I do not see any reason to behave differently.

[mauritsvanrees]

I am beginning to think we should be using constrain_package_deps = true in all tox ends, not just in circular, also when using mxdev. (It would be fine to keep this as an option so people can explicitly set it to false in .meta.toml if they know what they are doing.)

See https://github.com/plone/plone.app.multilingual/pull/452. In the first commit I set constrain_package_deps = true for the circular env, which fixed that. But the test and coverage env were broken. I fixed that with the second commit. See that commit for the test error that this fixed.

Let's first see if @ericof remembers why he wanted constrain_package_deps to be false when using mxdev.

[gforcada]

Thanks, indeed, I'm not sure why we did not do that for all envs 😓 I'm quite new at using tox so there is probably plenty of room for improvements 👍🏾