search

plone / meta

Meta issues concerning many/all of the plone repositories.
4 stars 4 forks source link

Regex for coverage doesn't match in .gitlab-ci #222

Open 1letter opened 4 months ago

1letter commented 4 months ago

The regex doesn't match for the coverage report in my gitlab instance, if disable the markdown option then all work as expected

gforcada commented 4 months ago

Weird... it works for me ™️ we have a few customizations on .meta.toml but none that changes the tox coverage environment 🤔

My output in gitlab looks like this:

|   **TOTAL** | **5599** |  **123** |  **794** |   **61** | **97%** |           |

So the regex /TOTAL.* \*\*(\d+)\%\*\*/ does match the 97%.

How does your output look like? 🤔

Which version of coverage do you have installed? The output above is from coverage==7.4.0

1letter commented 4 months ago

@gforcada Sorry it was my mistake, i have an old regex in my gitlab-ci file, copy&paste error 😦. But i found another bug. zope.testrunner is pinnend in Plone 6.0 and Plone 6.1 constraints file to v6.2.x, but the line - tox -e test -- --xml reports is only supported by zope.testrunner >= v6.3 https://pypi.org/project/zope.testrunner/#section-3

Traceback from my gitlab instance:

zope-testrunner: error: unrecognized arguments: --xml
test: exit 2 (0.53 seconds) /builds/xxx> zope-testrunner --all --test-path=/builds/xxx/src -s my.addon --xml reports pid=770
  test: FAIL code 2 (172.31=setup[105.35]+cmd[66.43,0.53] seconds)
  evaluation failed :( (172.41 seconds)
Uploading artifacts for failed job
00:01
Uploading artifacts...
WARNING: reports/testreports/*.xml: no matching files. Ensure that the artifact path is relative to the working directory (/builds/xxx) 
ERROR: No files to upload                          
Cleaning up project directory and file based variables
00:01
ERROR: Job failed: exit code 1
gforcada commented 4 months ago

Oh, indeed, I see that locally I have an override to it on my local versions.cfg, but we should update that upstream as well 👍🏾