search

plone / mockup

A collection of client side patterns for faster and easier web development
http://plone.github.io/mockup/
BSD 3-Clause "New" or "Revised" License
47 stars 93 forks source link

Recurrence widget does not set end recurrence by default #1308

Closed csanahuja closed 1 year ago

csanahuja commented 1 year ago

In Plone 6.0 the recurrence widget by default it is initialized without checking any recurrence end.

I have being comparing the old jquery.recurrenceinput.js with the new recurrence.js. But no idea where is the error.

Seems this line is not respected: https://github.com/plone/mockup/blob/master/src/pat/recurrence/templates/form.xml#L244

petschki commented 1 year ago

Can you try if this is still an issue with the latest Plone release 6.0.4 ... we had some UI fixes in recurrence widget there.

csanahuja commented 1 year ago

Tested with: Plone 6.0.4 (6015), still same behavior

petschki commented 1 year ago

OK I figured out the problem: there's a configuration flag hasRepeatForeverButton where the script want's to select per default NOENDDATE but the widget configuration is set to False in the behavior here https://github.com/plone/plone.app.event/blob/master/plone/app/event/dx/behaviors.py#L148 so the radio isn't available ...

long story short: I'll fix that today

EDIT: https://github.com/plone/mockup/pull/1313