search

plone / mockup

A collection of client side patterns for faster and easier web development
http://plone.github.io/mockup/
BSD 3-Clause "New" or "Revised" License
47 stars 93 forks source link

Fix duplicated image node when updateing already inserted image. [5.1.x] #1370

Closed petschki closed 7 months ago

petschki commented 7 months ago

fixes https://github.com/plone/Products.CMFPlone/issues/3910

pbauer commented 7 months ago

How do I test that? I forgot how to get Plone to use the raw js instead of the minified bundle.

petschki commented 7 months ago
  1. checkout mockup
  2. run yarn install && yarn start:webpack inside the package
  3. in the resource controlpanel go to the plone bundle and use http://localhost:8000/bundle.min.js as javascript resource
pbauer commented 7 months ago

I tested https://github.com/plone/plone.staticresources/pull/323 with 6.1 and it worked.

yarn start:webpack did not work:

mockup git:(5.1.x) $ yarn start:webpack
command not found: webpack`
petschki commented 7 months ago

yarn start:webpack did not work:

hm ... strange. maybe this is because of yarn version ... mockup only runs in yarn < 2

I'll prepare releases now for the fix.