plone / mr.roboto

Keep github and jenkins in sync
http://jenkins.plone.org/roboto
1 stars 3 forks source link

icalendar: only run the changelog test. #119

Closed mauritsvanrees closed 1 year ago

mauritsvanrees commented 1 year ago

See https://github.com/collective/icalendar/pull/514#issuecomment-1506108571 and following comments. From a Plone core development perspective, icalendar is a third party package since a while. It is used a lot outside of Plone, and is taken care of by people who are not core Plone developers.

The plone.app.event tests are run on every PR of this package, see yaml file and tox.ini. I keep tabs on new versions, and manually update its version in buildout.coredev. So nothing is needed on Jenkins, so mr.roboto does not need to do anything. I have removed the roboto hooks in the settings of the icalendar repo.

But: checking for a changelog entry is still wanted. That is where this PR comes in:

  1. Add icalendar to all ignore lists, except for the required changelog. (Also sort them alphabetically.)
  2. Fix the githubcommithooks endpoint to look for a single repo in the collective if it is not in Plone.

With this in place, I can enable the hooks again for this single repo, and only the changelog entry would be checked.

mauritsvanrees commented 1 year ago

This seems not deployed yet, I get an error when I try to enable the hook on the repo, saying that the repo is not found:

https://jenkins.plone.org/roboto/run/githubcommithooks?token=SECRET&repo=icalendar

gforcada commented 1 year ago

🤔 I kind of remember deploying it, but let me double check it 🍀

gforcada commented 1 year ago

Indeed it was not deployed 🤚🏾 now it is 🚀

mauritsvanrees commented 1 year ago

Thanks! I have enabled the hooks on icalendar now.