Closed mauritsvanrees closed 1 year ago
This seems not deployed yet, I get an error when I try to enable the hook on the repo, saying that the repo is not found:
https://jenkins.plone.org/roboto/run/githubcommithooks?token=SECRET&repo=icalendar
🤔 I kind of remember deploying it, but let me double check it 🍀
Indeed it was not deployed 🤚🏾 now it is 🚀
Thanks! I have enabled the hooks on icalendar now.
See https://github.com/collective/icalendar/pull/514#issuecomment-1506108571 and following comments. From a Plone core development perspective,
icalendar
is a third party package since a while. It is used a lot outside of Plone, and is taken care of by people who are not core Plone developers.The
plone.app.event
tests are run on every PR of this package, see yaml file andtox.ini
. I keep tabs on new versions, and manually update its version inbuildout.coredev
. So nothing is needed on Jenkins, somr.roboto
does not need to do anything. I have removed the roboto hooks in the settings of theicalendar
repo.But: checking for a changelog entry is still wanted. That is where this PR comes in:
icalendar
to all ignore lists, except for the required changelog. (Also sort them alphabetically.)githubcommithooks
endpoint to look for a single repo in the collective if it is not in Plone.With this in place, I can enable the hooks again for this single repo, and only the changelog entry would be checked.