search

plone / mr.roboto

Keep github and jenkins in sync
http://jenkins.plone.org/roboto
1 stars 3 forks source link

Do not update buildout.coredev on PRs that have a `[ci-skip]` message #138

Closed gforcada closed 1 year ago

gforcada commented 1 year ago

As @mauritsvanrees found out, we are only partially following the [ci-skip] message when merging a PR.

Either we check for [ci-skip] before firing the MergedPullRequest event (on these lines) or we rather do it on the event subscriber (on these class).

The second feels more natural, as there are plenty of checks there already.

We might even recycle some of the logic on the direct commits case ♻️

🍀

gforcada commented 1 year ago

Finally, after a few tries and back and forth, https://github.com/plone/plone.registry/pull/28 was merged with a [ci-skip] message on the PR commit message and mr.roboto did not update buildout.coredev 🎉