plone / mr.roboto

Keep github and jenkins in sync
http://jenkins.plone.org/roboto
1 stars 3 forks source link

mr.roboto did not trigger Jenkins builds #143

Closed davisagli closed 1 year ago

davisagli commented 1 year ago

I asked mr.roboto to trigger Jenkins PR builds on https://github.com/plone/plone.restapi/pull/1653, but nothing was triggered.

The github webhook log shows that the webhook for creation of the comment got this response:

Screenshot 2023-06-05 at 4 28 56 PM

(from https://github.com/plone/plone.restapi/settings/hooks/401195613?tab=deliveries)

That seems strange since the comment was brand new!

Any ideas @gforcada?

davisagli commented 1 year ago

I tried it again this evening and it worked now.

gforcada commented 1 year ago

🤔 I see a debug message saying:

2023-06-06 00:49:22,870 INFO  [mr.roboto][waitress-1] PR plone/plone.restapi#1653: commit does not have committer user info

And right after a traceback:

Traceback (most recent call last):
  File "/srv/mr.roboto/src/mr.roboto/src/mr/roboto/subscriber.py", line 194, in check_membership
    login = commit_info[user]["login"]
            ~~~~~~~~~~~^^^^^^
TypeError: string indices must be integers, not 'str'

But that looks weird, as on that PR all commits are done by you 🤷🏾 maybe a fluke with GitHub API? 🤔

There is another traceback with:

  File "/srv/mr.roboto/src/mr.roboto/src/mr/roboto/subscriber.py", line 235, in run
    not_foundation, unknown = self.check_membership(json_data)
                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/mr.roboto/src/mr.roboto/src/mr/roboto/subscriber.py", line 197, in check_membership
    unknown.append(commit_info["commit"]["author"]["name"])
                   ~~~~~~~~~~~^^^^^^^^^^
TypeError: string indices must be integers, not 'str'

As if the commit_info was not a single commit, but a list of commits... 🤔

If it worked a few hours later, then I would think of a fluke 🍀