Do not add Jenkins comment for plone.releaser PRs.

plone / mr.roboto

Keep github and jenkins in sync

http://jenkins.plone.org/roboto

1 stars 3 forks source link

Do not add Jenkins comment for plone.releaser PRs. #161

Closed mauritsvanrees closed 2 months ago

mauritsvanrees commented 2 months ago

We already have it in the IGNORE_NO_TEST_NEEDED, but the comment asking to trigger Jenkins jobs is still added.

Actually, if a package is in IGNORE_NO_TEST_NEEDED, then even if you would trigger Jenkins jobs, nothing would happen, if I follow the code correctly. Indeed, I added that comment for triggering the jobs, but the robots log says:

INFO COMMENT plone/plone.releaser#76-2343059679: skip triggering jenkins jobs, repo is ignored

So let me add another commit to this PR to add the IGNORE_NO_TEST_NEEDED packages to IGNORE_NO_JENKINS.

mauritsvanrees commented 2 months ago

In fact, I think the two lists can be merged. Currently, if a package is in IGNORE_NO_JENKINS but not in IGNORE_NO_TEST_NEEDED, then:

On a PR you will not get asked to run Jenkins jobs.
But if you add that comment anyway, it gets ignored. [Update: no wait, the Jenkins jobs do get run then I think, but they should not have an influence on Jenkins. Otherwise why would this package be listed in IGNORE_NO_JENKINS?]

So I think we should merge the two lists. I have not yet done so in this PR.

@gforcada Can you check if my reasoning is correct?

gforcada commented 2 months ago

Looks you are right, the two lists could be merged 👍🏾

We can keep it like this PR that you made, and later do a follow up PR.

I will merge and deploy it.