plone / papyrus

A buildout to run multiple versions of the plone documentation
GNU General Public License v2.0
8 stars 7 forks source link

Update Makefile #30

Closed svx closed 10 years ago

svx commented 10 years ago

If I do ' make html ' per default robot-tests are running, is it possible to change that, or add another command to the Makefile which is building html but not running the robots ?

If that would be possible, that would help a lot and also resolve a couple of issues :)

datakurre commented 10 years ago

See conf.py in documentstion repo. There's a Sphinx setting for it and if not else, it can be made overridable with environment variable (since conf.py is just Pyrhon).

sven kirjoitti Sun Sep 28 2014 19:38:37 GMT+0300 (EEST):

If I do ' make html ' per default robot-tests are running, is it possible to change that, or add another command to the Makefile which is building html but not running the robots ?


Reply to this email directly or view it on GitHub: https://github.com/plone/papyrus/issues/3

svx commented 10 years ago

I see the settings in the con.py that we already have:

Enable Robot Framework tests during Sphinx compilation:

sphinxcontrib_robotframework_enabled = True # 'True' is the default sphinxcontrib_robotframework_quiet = True # 'False' is the default

so how can we make this overridable ?

svx commented 10 years ago

$(SPHINXBUILD) -b html -D sphinxcontrib_robotframework_enabled=False $(ALLSPHINXOPTS) build/testtest

seems not to work so far

datakurre commented 10 years ago

It's the first one.

Something like

..._enabled = bool(os.environ.get('ROBOT'))

Then it only runs when ROBOT env is set.

sven kirjoitti Sun Sep 28 2014 19:56:33 GMT+0300 (EEST):

I see the settings in the con.py that we already have:

Enable Robot Framework tests during Sphinx compilation:

sphinxcontrib_robotframework_enabled = True # 'True' is the default sphinxcontrib_robotframework_quiet = True # 'False' is the default

so how can we make this overridable ?


Reply to this email directly or view it on GitHub: https://github.com/plone/papyrus/issues/30#issuecomment-5709165

datakurre commented 10 years ago

Here 'False' may be interpreted as string and bool('False') is always True.

sven kirjoitti Sun Sep 28 2014 20:19:32 GMT+0300 (EEST):

$(SPHINXBUILD) -b html -D sphinxcontrib_robotframework_enabled=False $(ALLSPHINXOPTS) build/testtest

seems not to work so far


Reply to this email directly or view it on GitHub: https://github.com/plone/papyrus/issues/30#issuecomment-5709248

polyester commented 10 years ago

booleans need to be '0', not 'false'. -D sphinxcontrib_robotframework_enabled=0 works fine in my tests. Robots keep on dreaming of electric sheep, and do not get woken up.

PS also the -j N (where N is number of threads) really helps in multicore machines. Buildtime from scratch is definitely down a lot for me on a laptop. So, easiest would be to create a "make quick" or something in the Makefile, that does not delete _robot/*.png and then does include these options is by far the simplest option.

svx commented 10 years ago

Yes ! that was it I added a new Makefile setting: "debug-eng" which build build html docs without robots, also I set the cores as per default to 4 for this setting.