search

plone / plone.act

DEPRECATED Acts, not words : ACceptance Testing for Plone
2 stars 2 forks source link

Demonstrate RF python-based Variable Files and added new library keyword "Apply Profile" #4

Closed emanlove closed 12 years ago

emanlove commented 12 years ago

Demonstrate how instead of creating special keywords to bring in p.a.testing variables, like SITE_OWNER_NAME and SITE_OWNER_PASSWORD, these can be brought in directly using variable file. See plone.act/acceptance-tests/rf_variable_file.txt example.

Also attempted to create an "Apply Profile" keyword so that using Godefroid's method one could apply a profile during "Suite setup". This keyword is not working properly and I am debugging currently.

datakurre commented 12 years ago

@emanlove

Are you sure that there's not too much magic in using variables file instead of per variable keywords? Currently, Travis-tests fail because of that and I cannot follow, what exactly causes the failure.

Also, I'm a little bit worried of adding keywords for things that we have traditionally done in p.a.testing layer setup, but I'm not fully against it either. Are there reasons, why it is part of Zope2ServerLibrary instead of PloneLibrary?

I'd prefer to keep Zope2ServerLibrary as minimal as possible. Of course, implementing that keyword in PloneLibrary would need more code: getting the site (hey, we could depend on plone.api in that!) and calling GenericSetup-API directly.

datakurre commented 12 years ago

@emanlove, You got it fixed. Great!

@gotcha, Is the proposed refactoring for Zope2ServerLibrary ok? (I haven't used it, so I don't know.)

emanlove commented 12 years ago

Closing this pull request as I happened to corrupt it by re-merging in plone/plone.act into emanlove/plone.act before this request was completed.