search

plone / plone.api

The Plone API
https://6.docs.plone.org/plone.api
Other
86 stars 53 forks source link

Further improvements to the tox PR #453

Closed mauritsvanrees closed 3 years ago

mauritsvanrees commented 3 years ago

This is a PR for merging into the branch of PR https://github.com/plone/plone.api/pull/431

@loechel I already merged master into your branch, because there were two minor conflicts.

For this PR, see the individual commits. It also drops support for Plone 5.1 and earlier. See also https://github.com/plone/plone.api/issues/450

Locally, the 2.7 tests fail, but that has a weird cause. I will open an issue for that. The other tox tests pass.

thet commented 3 years ago

@mauritsvanrees can this be merged to master as soon as the travis failures are resolved?

and should we also switch to github actions? I'm thinking of adding support for that.

mauritsvanrees commented 3 years ago

I would like to use GitHub Actions, yes. The plug on travis-co.org has not been pulled yet, but that is a matter of time.

This part of the PR drops testing on 5.1 and earlier, which should be okay, but we may want to wait on a resolution of the discussion in https://github.com/plone/plone.api/issues/450

Other than the supported versions, biggest question of this PR and the parent PR of Alexander, is if the docs tox env still works, and if this is needed for building the documentation on docs.plone.org. Currently it fails on Travis, so maybe there is some more work to do.

mauritsvanrees commented 3 years ago

Travis is green. I merge to the PR branch of @loechel