search

plone / plone.api

The Plone API
https://6.docs.plone.org/plone.api
Other
86 stars 53 forks source link

Fix regex asserts #514

Closed gforcada closed 11 months ago

gforcada commented 11 months ago

That's part of https://github.com/plone/Products.CMFPlone/issues/3852 effort

mister-roboto commented 11 months ago

@gforcada thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

jensens commented 11 months ago

Why are there still tests for 5.2? Should we run plone.meta on this before merging here?

mauritsvanrees commented 11 months ago

Coredev 5.2 uses branch 1.x, so from that point of view it is fine to drop 5.2 support.

gforcada commented 11 months ago

@jensens @mauritsvanrees on #519 I fixed the plone/python versions being tested, so that PRs can actually pass 👍🏾

This one should work now 🍀

gforcada commented 11 months ago

@jenkins-plone-org please run jobs

gforcada commented 11 months ago

@jensens plone/meta is on #509 I will rebase it and there were a few things that needed discussion, or that I was not 100% sure on how to handle them

gforcada commented 11 months ago

The failing 3.12 job is expected, as we are missing some version pins from https://github.com/plone/buildout.coredev/pull/890 which in turn fails on 3.12 because it's missing the fixes here 🥚 🐔

gforcada commented 11 months ago

Merging as it works on 6.0/1 and it is needed for Python 3.12 👍🏾