plone / plone.api

The Plone API
https://6.docs.plone.org/plone.api
Other
86 stars 53 forks source link

Fix failing tests related to object_provides index #518

Closed Akshat2Jain closed 10 months ago

Akshat2Jain commented 11 months ago

this pr is related to #3836

mister-roboto commented 11 months ago

@Akshat2Jain thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

wesleybl commented 11 months ago

@Akshat2Jain Please click on the link Plone Jenkins CI - pull-request-6.1-3.11 below and put the link this PR and the PR https://github.com/plone/Products.CMFPlone/pull/3836, so that you can test them be executed with these two PR.

And in the Plone 6.0 tests, put the link to this PR and https://github.com/plone/Products.CMFPlone/pull/3856

jaroel commented 11 months ago

@jenkins-plone-org please run jobs

jaroel commented 11 months ago

https://jenkins.plone.org/job/pull-request-6.1-3.11/336/ is running this PR + https://github.com/plone/Products.CMFPlone/pull/3836

wesleybl commented 11 months ago

@jaroel thanks for taking care of this!

Now we no longer have IContentish we no longer need to run the jobs from this PR together with the CMFPlone PR. I started job 6.1-3.11 with just this PR.

wesleybl commented 11 months ago

@jenkins-plone-org please run jobs

jaroel commented 11 months ago

@jenkins-plone-org please run jobs

jaroel commented 11 months ago

@jaroel Python 3.12 tests are failing. Please update the branch with:

514

Done; you are allowed to do so too, there is no need for me specifically to do it. Thanks for pointing is out though. I figured that might be it and that these failures wouldn't be a problem.

wesleybl commented 10 months ago

@Akshat2Jain @davisagli @jaroel thanks!