search

plone / plone.api

The Plone API
https://6.docs.plone.org/plone.api
Other
86 stars 53 forks source link

Issue 312: unrestricted find #522

Closed gogobd closed 6 months ago

gogobd commented 10 months ago

Maybe we want this; unrestricted find is necessary because proxy roles are not being handled correctly atm.

mister-roboto commented 10 months ago

@gogobd thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

gogobd commented 10 months ago

In https://github.com/plone/plone.api/pull/523 @ksuess suggested to stick to one Pull Request, so I reopen...

mister-roboto commented 10 months ago

@gogobd thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

gogobd commented 10 months ago

@jenkins-plone-org please run jobs

gogobd commented 6 months ago

@jenkins-plone-org please run jobs

gogobd commented 6 months ago

I have no idea what this "tox linkcheck" wants to do, please help.

stevepiercy commented 6 months ago

@gogobd see https://github.com/plone/plone.api/blob/master/tox.ini#L186-L197

stevepiercy commented 6 months ago

Argh, it's that thing again. I'll push a commit to this PR that will fix it.

  The sphinxcontrib.applehelp extension used by this project needs at least Sphinx v5.0; it therefore cannot be built with this version.
stevepiercy commented 6 months ago

Actually, I'll push a separate PR so it has its own changelog, and you can cherry pick it.

stevepiercy commented 6 months ago

Forget that, it already was fixed two weeks ago in https://github.com/plone/plone.api/commit/4b91ad80f4d96a92b374f7c3e12de7ae65fa5628, which was released in plone.api 2.0.9.

Hmm, for some reason tox -e linkcheck does not use the pinned version of sphinxcontrib-applehelp==1.0.4 in https://github.com/plone/plone.api/blob/master/requirements-docs.txt#L14C1-L14C14, but instead uses sphinxcontrib-applehelp==1.0.8. Why is that?

https://github.com/plone/plone.api/actions/runs/7981002081/job/21791817987?pr=522#step:6:14 says linkcheck: install_deps> python -I -m pip install -r requirements-docs.txt.

Later that gets clobbered in https://github.com/plone/plone.api/actions/runs/7981002081/job/21791817987?pr=522#step:6:23 with linkcheck: install_package> python -I -m pip install --force-reinstall --no-deps /home/runner/work/plone.api/plone.api/.tox/.tmp/package/1/plone.api-2.0.7.dev0-0.editable-py3-none-any.whl. Why is it 2.0.7 and not 2.0.9?

This is above my pay grade for how to resolve.

wesleybl commented 6 months ago

The branch needs to be updated.

gogobd commented 6 months ago

YAY! Thanks, every 01!