plone / plone.api

The Plone API
https://6.docs.plone.org/plone.api
Other
86 stars 53 forks source link

Issue 312; Unrestricted find #523

Closed gogobd closed 10 months ago

gogobd commented 10 months ago

Fix #312

Maybe we want this; unrestricted find is necessary because proxy roles are not being handled correctly atm.

mister-roboto commented 10 months ago

@gogobd thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

ksuess commented 10 months ago

It's far easier to review or at least read if you stick to one PR.

gogobd commented 10 months ago

@ksuess Ok, sorry next time I will stay on one pull request! Thanks for letting me know!