search

plone / plone.api

The Plone API
https://6.docs.plone.org/plone.api
Other
88 stars 53 forks source link

Issue 479: Edited api.content.get_view for increased efficiency to get views #528

Closed samriddhi99 closed 8 months ago

samriddhi99 commented 9 months ago

The function does some avoidable check to wake up the view. I have used a try-except block avoid doing the check unless there is an error that pops up. FIxes #479

mister-roboto commented 9 months ago

@samriddhi99 you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

mister-roboto commented 9 months ago

@samriddhi99 thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

samriddhi99 commented 9 months ago

@jenkins-plone-org please run jobs

mister-roboto commented 9 months ago

@samriddhi99 you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

gforcada commented 8 months ago

@samriddhi99 thanks for this contribution, hopefully we get all the ticks green ✅ and can merge it soon! 🤩

There is one tick that you need to work on though: the contributor agreement, please read about it and sign it 🤞🏾 https://plone.org/foundation/contributors-agreement

stevepiercy commented 8 months ago

@gforcada it appears @samriddhi99 was approved and added to the Contributors team after mister-roboto sent the reminder.

stevepiercy commented 8 months ago

Something is not quite right. @samriddhi99 was added to the Plone Contributors Team in GitHub, but mister-roboto says otherwise. It's possible that the emails in @samriddhi99's GitHub account do not align with what they put on their Agreement.

@samriddhi99 would you please add the email you put on your agreement to your GitHub account? If you already did that, it is possible that there is a typo somewhere, and you should contact agreements@plone.org, copying and pasting a link to this issue in reference to this issue.

samriddhi99 commented 8 months ago

@stevepiercy The plone contributors agreement verifier check has passed, so I think the issue has been resolved.

stevepiercy commented 8 months ago

@samriddhi99 thank you, and I confirm. You're not the only person that experienced a similar issue.

After all other checks pass, please read and follow this comment: https://github.com/plone/plone.api/pull/528#issuecomment-1918427786

samriddhi99 commented 8 months ago

@jenkins-plone-org please run jobs