search

plone / plone.api

The Plone API
https://6.docs.plone.org/plone.api
Other
86 stars 53 forks source link

Enhance Path Handling in Makefile #530

Closed Vivek-04022001 closed 6 months ago

Vivek-04022001 commented 6 months ago

Issue Description:

The Makefile uses realpath to set CURRENT_DIR:

CURRENT_DIR:=$(shell dirname $(realpath $(lastword $(MAKEFILE_LIST))))

replace with 

CURRENT_DIR:="$(shell dirname $(realpath $(lastword $(MAKEFILE_LIST))))"

This can cause compatibility issues and doesn't handle special characters in paths. We need to replace realpath with a more portable and robust method. This issues was already discussed with @stevepiercy on plone community conversation link

mister-roboto commented 6 months ago

@Vivek-04022001 thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

stevepiercy commented 6 months ago

@mauritsvanrees is it OK for me to merge, or do you want to do that as maintainer?