search

plone / plone.api

The Plone API
https://6.docs.plone.org/plone.api
Other
86 stars 53 forks source link

Overhaul contributing documentation for Plone 6 #539

Closed stevepiercy closed 1 month ago

stevepiercy commented 1 month ago

Now that we have Plone core contributing documentation, I've simplified and modernized the contributing documentation.

See https://github.com/plone/documentation/issues/1278.

After merging, then merge https://github.com/plone/documentation/pull/1684.

mister-roboto commented 1 month ago

@stevepiercy thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

stevepiercy commented 1 month ago

@jenkins-plone-org please run jobs

stevepiercy commented 1 month ago

I have no clue as to why Jenkins fails for Plone 6.0/Python 3.11 but not for Plone 6.0/Python 3.8. Help!

stevepiercy commented 1 month ago

@jenkins-plone-org please run jobs

stevepiercy commented 1 month ago

Changes made, and I excluded GNU make as a requirement here since this project uses tox instead.

It would be nice to use one of make or tox for all of Plone, don't you think?

ksuess commented 1 month ago

It would be nice to use one of make or tox for all of Plone, don't you think?

Yes, a switch to make would be consistent. Definitly.

stevepiercy commented 1 month ago

It would be nice to use one of make or tox for all of Plone, don't you think?

Yes, a switch to make would be consistent. Definitly.

See https://community.plone.org/t/tools-for-development-gnu-make-tox-or/19708