search

plone / plone.app.blocks

A 'blocks' rendering model for Plone
https://pypi.python.org/pypi/plone.app.blocks
Other
11 stars 4 forks source link

provide abilty to set default grid system #16

Closed vangheem closed 9 years ago

vangheem commented 9 years ago

@datakurre What do you think about this?

Additionally, perhaps we need a control panel for these?

vangheem commented 9 years ago

I wonder if we shouldn't use data-gridsystem attribute at all and just use the site setting? Otherwise, we won't be able to write generalized layouts that work with potentially any grid system. For instance, right now in plone.app.mosaic, we have identical layouts defined for plone 5 and 4 when it's not really necessary.

datakurre commented 9 years ago

I'd like it having a registry default, but also being overriddable with data-attribute. I think, it was kind of "ideal" in Deco design that everything could be in html. Registry would just give more convenience.

The attribute is not mandatory, so without the attribute, layouts would be generic?

Yet, probably this needs something more later to be compatible with the new theming policies. So that different sections could have different themes with different grid system. (My use case is to support e.g. small conference / event subsites with custom theme in a single Plone.)

Nathan Van Gheem kirjoitti to heinäkuuta 9 07:39:28 2015 GMT+0300:

I wonder if we shouldn't use data-gridsystem attribute at all and just use the site setting? Otherwise, we won't be able to write generalized layouts that work with potentially any grid system. For instance, right now in plone.app.mosaic, we have identical layouts defined for plone 5 and 4 when it's not really necessary.

Reply to this email directly or view it on GitHub: https://github.com/plone/plone.app.blocks/pull/16#issuecomment-11981635

vangheem commented 9 years ago

I agree, we need to keep the current behavior with the attribute.

So in plone.app.mosaic we should probably remove the use of that attribute with this change.

I think this PR is good to go though if you're okay merging.

datakurre commented 9 years ago

+1

p.a.mosaic may need some changes indeed. Probably removing data-attributes for this from example layouts. There is also a transform, which adds an additional body class if gridsystem is deco (to not apply deco classes for other gridsystems), which should now also check this setting.

Nathan Van Gheem kirjoitti to heinäkuuta 9 09:26:44 2015 GMT+0300:

I agree, we need to keep the current behavior with the attribute.

So in plone.app.mosaic we should probably remove the use of that attribute with this change.

I think this PR is good to go though if you're okay merging.

Reply to this email directly or view it on GitHub: https://github.com/plone/plone.app.blocks/pull/16#issuecomment-11983860

vangheem commented 9 years ago

Okay if I merge this?

datakurre commented 9 years ago

Please, do.