search

plone / plone.app.content

Various views for Plone, such as folder_contents, as well as general content infrastructure, such as base classes and name choosers.
https://pypi.org/project/plone.app.content/
7 stars 32 forks source link

Fix dxsiteroot vocabulary permission check #239

Closed jensens closed 2 years ago

jensens commented 2 years ago

I had strange behaviors with DX site root and vocabularies with permission. Mainly because of a even before questionable use of Navigation-root specialties. This simplifies the code and defines a clear policy, That said I even would not do a field permission check here. First, it can not be weaker than the primary permission. And with the "field" parameter it is accessible anyway then. Second the field would not render if the permission would not apply.

mister-roboto commented 2 years ago

@jensens thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

jensens commented 2 years ago

@jenkins-plone-org please run jobs

jensens commented 2 years ago

No idea if this is still a thing, at least the PR is outdated and needs a start over. I I stumble over this again, I will pick it up in a new PR.