search

plone / plone.app.content

Various views for Plone, such as folder_contents, as well as general content infrastructure, such as base classes and name choosers.
https://pypi.org/project/plone.app.content/
7 stars 32 forks source link

Refactoring, dead code removal, isort, black and use plone.base #243

Closed jensens closed 2 years ago

jensens commented 2 years ago

Sorry, this is a massive one and due to the nature of exploring and working on it I squashed the several meaningless commits with failures and my work history in one. It may still need some polishing, also not all dependencies to CMFPlone are gone - but most of it is untangled,

mister-roboto commented 2 years ago

@jensens thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

jensens commented 2 years ago

@jenkins-plone-org please run jobs

jensens commented 2 years ago

from my POV ready for merge. More in subsequent (and smaller) PRs

jensens commented 2 years ago

@jenkins-plone-org please run jobs

jensens commented 2 years ago

More findings replaced.

Note: plone_utils.contentEdit is still left, and this is a hell of a function. This needs to be tackled later.

jensens commented 2 years ago

@jenkins-plone-org please run jobs

jensens commented 2 years ago

@jenkins-plone-org please run jobs

jensens commented 2 years ago

And plone_utils.browserDefault is left too. After the recent merge of removal of PloneFolder the method could be moved to plone.base now, but keep this for later. First get this thing here in.

jensens commented 2 years ago

@jenkins-plone-org please run jobs

mauritsvanrees commented 2 years ago

One failure left, in plone.app.content.tests.test_reviewlist.ReviewListTestCase.test_with_content.

jensens commented 2 years ago

All green. I started the tests several times in short intervals and so the broken ones reported back first. I do not have permissions to cancel Jenkins jobs.