search

plone / plone.app.content

Various views for Plone, such as folder_contents, as well as general content infrastructure, such as base classes and name choosers.
https://pypi.org/project/plone.app.content/
7 stars 32 forks source link

Various fixes for custom json handler #247

Closed mauritsvanrees closed 2 years ago

mauritsvanrees commented 2 years ago

Needed for the work-in-progress image_scales catalog PR https://github.com/plone/Products.CMFPlone/pull/3521.

Fixes https://github.com/plone/plone.app.content/issues/246, which is the main problem. Also fixes the similar https://github.com/plone/plone.app.content/issues/128.

mister-roboto commented 2 years ago

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

mauritsvanrees commented 2 years ago

@jenkins-plone-org please run jobs