search

plone / plone.app.content

Various views for Plone, such as folder_contents, as well as general content infrastructure, such as base classes and name choosers.
https://pypi.org/project/plone.app.content/
7 stars 32 forks source link

1letter/fix #178 #254

Open 1letter opened 2 years ago

1letter commented 2 years ago

Fix datetime settings in fc-properties view

mister-roboto commented 2 years ago

@1letter thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

jensens commented 2 years ago

This mixes the currently stored DateTime with the newly stored datetime. I agree we need to store datetime with timezone everywhere, so for created, modified, effective and expiration. But this gets complex. Just changing it in one place seems dangerous to me. Any opinions?

erral commented 2 years ago

We already discussed many times the issue with datetimes and timezones. I think the last one was in the context of plone.restapi may be @thet and/or @tisto will remember which was the agreement here.

mauritsvanrees commented 2 years ago

As release manager I get nervous when I see such a change during beta...

jensens commented 2 years ago

We already discussed many times the issue with datetimes and timezones.

There is no issue, just store a timezone as pytz (never as offset) with the datetime and all is fine.

jensens commented 2 years ago

during beta.

Changing this is a a PLIP and is complex, so IMO for a 6.1: ok. But not now.

thet commented 2 years ago

@erral the discussion from the 2018 Bonn sprint is here: https://github.com/plone/plone.restapi/pull/493 In short - ISO8601 as a date format for date/times in plone.restapi does not support timezone information - only timezone offsets. For exchanging data it's necessary to convert everything to UTC. But I think this is a different discussion...