plone / plone.app.content

Various views for Plone, such as folder_contents, as well as general content infrastructure, such as base classes and name choosers.
https://pypi.org/project/plone.app.content/
7 stars 32 forks source link

Fixup test_delete_wrong_object_by_acquisition_with_action. #263

Closed jaroel closed 1 year ago

jaroel commented 1 year ago

We won't publish acquired content items anymore. Refs https://github.com/zopefoundation/Products.CMFCore/pull/129

mister-roboto commented 1 year ago

@jaroel thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

jaroel commented 1 year ago

@plone/ai-team Could someone help with that pre-commit.ci - pr — error during ci config error?

gforcada commented 1 year ago

Fixed, I disabled pre-commit hook, as it is still not merged from #262

mister-roboto commented 1 year ago

@jaroel thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

gforcada commented 1 year ago

🤔 seems it is still there, probably if you push a new commit it will now show up again 🍀

jaroel commented 1 year ago

@jenkins-plone-org please run jobs

polyester commented 1 year ago

pre-commit-ci wasn't enabled on plone.app.content, I enabled it on that repo

gforcada commented 1 year ago

@polyester no, I just disabled it on purpose, because it still needs #262 to get merged first 😅