search

plone / plone.app.content

Various views for Plone, such as folder_contents, as well as general content infrastructure, such as base classes and name choosers.
https://pypi.org/project/plone.app.content/
7 stars 32 forks source link

Move `INameFromTitle` interface to `plone.base` #271

Closed gforcada closed 1 year ago

gforcada commented 1 year ago

Part of https://github.com/plone/Products.CMFPlone/issues/3858

This needs https://github.com/plone/plone.base/pull/51 to be merged and released.

It needs all other mentioned PRs on the tracking issue to be merged first.

mister-roboto commented 1 year ago

@gforcada thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

mauritsvanrees commented 1 year ago

I have released a new plone.base version and updated the constraints at https://dist.plone.org/release/6.0-dev/ so should be fine now. I will test this together with https://github.com/plone/plone.app.dexterity/pull/379 on Jenkins.

mauritsvanrees commented 1 year ago

Actually, tox -e test fails on the plone.app.dexterity PR, so that needs to be fixed first. So let's test only this PR for now:

@jenkins-plone-org please run jobs

mauritsvanrees commented 1 year ago

Unfortunately, the deferred import breaks content types that still refer to the interface in their behaviors list. Inheriting from the new interface fixes it. This works in combination with https://github.com/plone/plone.app.dexterity/pull/380.