search

plone / plone.app.content

Various views for Plone, such as folder_contents, as well as general content infrastructure, such as base classes and name choosers.
https://pypi.org/project/plone.app.content/
7 stars 32 forks source link

No longer check visible_ids on the 'select default page' form. #283

Closed mauritsvanrees closed 5 months ago

mauritsvanrees commented 5 months ago

Usage of visible_ids was largely removed in Plone 5.0 already, and you cannot change the setting on the portal or the member. This was using the deprecated portal_properties tool. See also https://github.com/plone/plone.app.contenttypes/pull/693

I think this is fine in Plone 6.0 already. If this part was still working, then the 'select default page' form would look like this, showing the ids in brackets. Sorry, Dutch text:

Screenshot 2024-06-06 at 23 34 35

mister-roboto commented 5 months ago

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

mauritsvanrees commented 5 months ago

@jenkins-plone-org please run jobs