search

plone / plone.app.contentlisting

Generic way to make listings of Plone content
2 stars 8 forks source link

Add CI #32

Closed gotcha closed 4 years ago

gotcha commented 4 years ago

on Circle Drone GHA Travis

mauritsvanrees commented 4 years ago

@gotcha Circle CI ran successfully 9 months ago when you added it, but that was also the last time that it ran successfully. Circle CI complains that its config file does not exist. Can you have a look?

Ah, wait, I see: the config file is there, but only on branch 1.3.x. Was that what you wanted? Can you see if you can disable the tests on master / PRs? Is that something that you can do from the GitHub Ui or is this in Circle CI? For example, my PR #35 gave a Circle CI build error.

In general, for core packages I prefer to only use Jenkins. That is hard enough to keep green. But there are certainly cases where some extra testing is useful, especially for packages and recipes that are a bit more standalone.