search

plone / plone.app.discussion

General commenting system for Plone content
https://pypi.org/project/plone.app.discussion
16 stars 47 forks source link

"Reply" not working in p.a.d 3.2/Plone 5.2RC3 #157

Closed zopyx closed 5 years ago

zopyx commented 5 years ago

The "Reply" button is supposed to unhide/open the textarea/form for a reply.

This does not work in Plone 5.2rc3.

Tested and reproducible on www.plone-demo.info

tisto commented 5 years ago

@zopyx any tracebacks in python or js?

zopyx commented 5 years ago

nothing - double checked the issue with the plone.de demo sites...same issue

http://demo-latest-py3.plone.org2 and http://demo-latest-py2.plone.org2 are running master of Plone 5.2.

pbauer commented 5 years ago

Confirmed. The js comment.js is not part of the legacy-bundle and thus not there. I tried to fix that in #158 but got stuck.

pbauer commented 5 years ago

I guess this also needs a upgrade-step.

pbauer commented 5 years ago

I see the same problem with a other addons that use legacy js (e.g. eea.facetednavigation)

pbauer commented 5 years ago

https://github.com/plone/plone.app.discussion/pull/158 in combination with https://github.com/plone/Products.CMFPlone/pull/2899 fixes this.

I'm not sure if this requires a upgrade-step.

thet commented 5 years ago

@pbauer see my comment in: https://github.com/plone/plone.app.discussion/pull/158#issuecomment-505327932

pbauer commented 5 years ago

https://github.com/plone/plone.app.discussion/pull/158 alone should fix the issue now. Upgrade-step is added and CMFPlone profile version is bumped to run that step when updating Plone (https://github.com/plone/Products.CMFPlone/pull/2902 and https://github.com/plone/plone.app.upgrade/pull/211)