search

plone / plone.app.discussion

General commenting system for Plone content
https://pypi.org/project/plone.app.discussion
16 stars 47 forks source link

Register old js in legacy bundle to fix missing js #158

Closed pbauer closed 5 years ago

pbauer commented 5 years ago

Same as in p.a.event. Fixes #157

This still yields because queryUtility(IResourceDirectory, name='persistent') cannot find a resource directory:

Traceback (innermost last):
  Module ZPublisher.WSGIPublisher, line 155, in transaction_pubevents
  Module ZPublisher.WSGIPublisher, line 337, in publish_module
  Module ZPublisher.WSGIPublisher, line 255, in publish
  Module ZPublisher.mapply, line 85, in mapply
  Module Products.PDBDebugMode.wsgi_runcall, line 60, in pdb_runcall
  Module Products.CMFPlone.browser.admin, line 273, in __call__
  Module Products.CMFPlone.factory, line 150, in addPloneSite
  Module Products.GenericSetup.tool, line 393, in runAllImportStepsFromProfile
   - __traceback_info__: profile-Products.CMFPlone:plone
  Module Products.GenericSetup.tool, line 1474, in _runImportStepsFromContext
  Module Products.GenericSetup.tool, line 1321, in _doRunHandler
  Module Products.CMFPlone.setuphandlers, line 144, in importFinalSteps
  Module Products.GenericSetup.tool, line 393, in runAllImportStepsFromProfile
   - __traceback_info__: profile-Products.CMFPlone:dependencies
  Module Products.GenericSetup.tool, line 1465, in _runImportStepsFromContext
  Module Products.GenericSetup.tool, line 1277, in _doRunImportStep
   - __traceback_info__: combine-bundles
  Module Products.CMFPlone.resources.exportimport.bundles, line 38, in combine
  Module Products.CMFPlone.resources.browser.combine, line 170, in combine_bundles
TypeError: argument of type 'NoneType' is not iterable

My guess was that it needed a <include package="plone.resource" /> in the configure.zcml of p.a.discussion but that did not fix it. Anyone?

mister-roboto commented 5 years ago

@pbauer thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

thet commented 5 years ago

For comparison, this is the PR from plone.app.event: https://github.com/plone/plone.app.event/pull/287 There is also the change from a <browser:resourceDirectory> to <plone:static>. A plone:static can live in the ZODB, which would explain the error you're facing.

pbauer commented 5 years ago

Done

pbauer commented 5 years ago

@jenkins-plone-org please run jobs

pbauer commented 5 years ago

@jenkins-plone-org please run jobs