Comments moderation: Additional workflow with states pending, approved, rejected and spam

[ksuess]

Moderator is not forced to delete a comment or to let it pending: Workflow has two more states "rejected" and "spam" to existing review workflow. Moderation view extended showing all states. Filter by state. see Issue https://github.com/plone/plone.app.discussion/issues/164

[mister-roboto]

@ksuess thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

[ksuess]

@jenkins-plone-org please run jobs

[ksuess]

https://github.com/collective/plone.app.locales/pull/285 adds the necessary translations.

So tests below run with https://github.com/plone/plone.app.discussion/pull/165 https://github.com/collective/plone.app.locales/pull/285

plus https://github.com/plone/plone.restapi/pull/843 https://github.com/plone/Products.CMFPlacefulWorkflow/pull/30 https://github.com/plone/Products.CMFPlone/pull/3002 for failing tests on additional workflow states.

https://github.com/plone/plone.app.discussion/pull/165
https://github.com/collective/plone.app.locales/pull/285
https://github.com/plone/plone.restapi/pull/843
https://github.com/plone/Products.CMFPlacefulWorkflow/pull/30
https://github.com/plone/Products.CMFPlone/pull/3002

[jensens]

Wow, that's a massive one :+1: I took a quick look and it is fine at a first look. I would like to check it out and test a bit, but at the moment no time.

Please test with collective/plone.app.locales#285

You can do this on your own as well, by starting them manual at jenkins (follow the details link).Just enter one pull request URL per line in the PULL_REQUEST_URL field.

[ksuess]

[ksuess]

Until now I thought to add an extended workflow with workflow states rejected and spam and a moderation view where also published comments are shown. @agitator proposed to extend the existing review workflow instead of adding an additional workflow. I like this idea. What do you think?

• Could there be admins of existing installations not amused to get an extended moderation view and additional workflow states as rejected and spam?
• Does it have any side effects extending the existing review workflow?

[ksuess]

Replaced by https://github.com/plone/plone.app.discussion/pull/166: No additional workflow, but extended existing workflow.