search

plone / plone.app.discussion

General commenting system for Plone content
https://pypi.org/project/plone.app.discussion
16 stars 47 forks source link

Test failures with fresh Products.MailHost 4.11 #174

Closed mauritsvanrees closed 3 years ago

mauritsvanrees commented 3 years ago

Fixes for line endings were done in Products.MailHost 4.11. While a PR for that was being made, I tested its branch with a PR in coredev. All tests were green. It now looks as if I did not add Products.MailHost to the auto-checkouts, but I am pretty sure I did. Anyway, too late for that.

Since I updated coredev 5.2 to Products.MailHost 4.11, two tests in plone.app.discussion fail on Python 3

Errors for example on 3.6:

False is not true

  File "/srv/python3.6/lib/python3.6/unittest/case.py", line 59, in testPartExecutor
    yield
  File "/srv/python3.6/lib/python3.6/unittest/case.py", line 605, in run
    testMethod()
  File "/home/jenkins/.buildout/eggs/cp36m/plone.app.discussion-3.4.3-py3.6.egg/plone/app/discussion/tests/test_notifications.py", line 217, in test_notify_moderator
    in msg)
  File "/srv/python3.6/lib/python3.6/unittest/case.py", line 682, in assertTrue
    raise self.failureException(msg)

and

False is not true

  File "/srv/python3.6/lib/python3.6/unittest/case.py", line 59, in testPartExecutor
    yield
  File "/srv/python3.6/lib/python3.6/unittest/case.py", line 605, in run
    testMethod()
  File "/home/jenkins/.buildout/eggs/cp36m/plone.app.discussion-3.4.3-py3.6.egg/plone/app/discussion/tests/test_notifications.py", line 75, in test_notify_user
    in msg)
  File "/srv/python3.6/lib/python3.6/unittest/case.py", line 682, in assertTrue
    raise self.failureException(msg)

I am looking into fixing it in the tests.