search

plone / plone.app.discussion

General commenting system for Plone content
https://pypi.org/project/plone.app.discussion
16 stars 47 forks source link

Plone base overhaul #195

Closed jensens closed 2 years ago

jensens commented 2 years ago
mister-roboto commented 2 years ago

@jensens thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

jensens commented 2 years ago

@jenkins-plone-org please run jobs

jensens commented 2 years ago

LGTM. Just two docs that still have explicit unicode strings.

Can you give me a hint where? pyupgrade only covers code, so that is probably why.

mauritsvanrees commented 2 years ago

LGTM. Just two docs that still have explicit unicode strings.

Can you give me a hint where? pyupgrade only covers code, so that is probably why.

git grep -w u finds them. I have fixed them and pushed a commit.

ksuess commented 2 years ago

LGTM. Just two docs that still have explicit unicode strings.

Can you give me a hint where? pyupgrade only covers code, so that is probably why.

docs: https://github.com/plone/plone.app.discussion/blob/bcb93157724d8044998853ab3a1f2a50ea99dda2/docs/source/howtos/howto_make_pad_work_with_a_dexterity_content_type.txt#L20-L28 https://github.com/plone/plone.app.discussion/blob/bcb93157724d8044998853ab3a1f2a50ea99dda2/docs/source/howtos/howto_extend_the_comment_form.txt#L59-L67

jensens commented 2 years ago

@jenkins-plone-org please run jobs