search

plone / plone.app.discussion

General commenting system for Plone content
https://pypi.org/project/plone.app.discussion
16 stars 47 forks source link

(re)move translations? #205

Closed gforcada closed 1 year ago

gforcada commented 1 year ago

@erral you might know better than me 🍀

While running codespell in this repository, oh surprise, the translations in i18n folder produce false positives.

While codespell does not ignore .po files by default, we have to find a solution.

But back to the point, are those translations there actually being used? 🤔

The only MessageFactory that is created is for plone:

plone/app/discussion/__init__.py:1:from zope.i18nmessageid import MessageFactory
plone/app/discussion/__init__.py:4:_ = MessageFactory("plone")

So the translations in the i18n could be removed or merged/migrated to plone.app.locales? 🤔

TIA! 🙇🏾

erral commented 1 year ago

The i18n folder is not used at all, we use the locales folder for ages...

Moreover the translations of p.a.discussion are included in p.a.locales see https://github.com/plone/buildout.coredev/blob/6.0/experimental/i18n.cfg#L46

gforcada commented 1 year ago

Ok, then I will remove that folder 👍🏾