search

plone / plone.app.discussion

General commenting system for Plone content
https://pypi.org/project/plone.app.discussion
16 stars 47 forks source link

Add missing icon #222

Closed gforcada closed 2 months ago

gforcada commented 9 months ago

I'm testing the upgrade to Plone 6 and noticed that on the toolbar when editing a comment the view action was missing an icon.

This fixes it.

That would require an upgrade step, should I add it here or on plone.app.upgrade? 🤔

mister-roboto commented 9 months ago

@gforcada thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

davisagli commented 9 months ago

@gforcada Either one is fine, since plone.app.discussion is in the list of core addon profiles whose upgrade steps are automatically run when Plone is upgraded: https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/MigrationTool.py#L101

mauritsvanrees commented 9 months ago

Adding an upgrade step in plone.app.discussion is probably easiest. Otherwise by now you would need two upgrade steps in plone.app.upgrade: one in v60 and one in v61.

jensens commented 6 months ago

Meanwhile with #211 in mind an upgrade step in here would be preferred.

mauritsvanrees commented 3 months ago

I have rebased this branch on 4.x and force pushed. I have changed the target of the PR from main to 4.x. I register a contenttype icon for comments, update the content_icon property, and add an upgrade profile/step. I will copy some of this into PR #211 for the main branch as well.

mauritsvanrees commented 3 months ago

@jenkins-plone-org please run jobs

mauritsvanrees commented 3 months ago

Wrong button...

mister-roboto commented 3 months ago

@gforcada thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

mauritsvanrees commented 3 months ago

@jenkins-plone-org please run jobs

mauritsvanrees commented 3 months ago

@jenkins-plone-org please run jobs

gforcada commented 2 months ago

Seems that all is good, should I merge?

@mauritsvanrees as you mostly overtook the PR, I leave that on you 😄