search

plone / plone.app.discussion

General commenting system for Plone content
https://pypi.org/project/plone.app.discussion
16 stars 47 forks source link

Do not autofocus on the comments form. #223

Closed mauritsvanrees closed 9 months ago

mauritsvanrees commented 9 months ago

Fixes https://github.com/plone/Products.CMFPlone/issues/3623

mister-roboto commented 9 months ago

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

mauritsvanrees commented 9 months ago

@jenkins-plone-org please run jobs

mauritsvanrees commented 9 months ago

@davisagli Thanks for all the reviews you keep doing. It is amazing how much you do, and very helpful!