search

plone / plone.app.discussion

General commenting system for Plone content
https://pypi.org/project/plone.app.discussion
16 stars 47 forks source link

Report progress #224

Closed gforcada closed 8 months ago

gforcada commented 9 months ago

While testing an upgrade from 5.2.x to 6.0.x I noticed that it first does a large upgrade step about the image_scale new catalog column, but then there's a laaaaaaarge gap of the server doing something without reporting anything at all 😱 is it dead? is still running? what is it doing?!

Adding these few lines of code solves the mystery 🎉

mister-roboto commented 9 months ago

@gforcada thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

gforcada commented 8 months ago

@jenkins-plone-org please run jobs