search

plone / plone.app.discussion

General commenting system for Plone content
https://pypi.org/project/plone.app.discussion
16 stars 47 forks source link

Fix test "Add a Comment to a Document and bulk delete it" #228

Closed wesleybl closed 8 months ago

wesleybl commented 8 months ago

Fix test robot. Waiting for the select option to be enabled does not guarantee that the selection will occur. Maybe because it is a modal loaded by ajax. Then we try to select the value 5x.

Even after https://github.com/plone/plone.app.discussion/pull/227, we still had failure. This is a new attempt to make the test more robust.

mister-roboto commented 8 months ago

@wesleybl thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

wesleybl commented 8 months ago

@jenkins-plone-org please run jobs

wesleybl commented 8 months ago

@jenkins-plone-org please run jobs