search

plone / plone.app.discussion

General commenting system for Plone content
https://pypi.org/project/plone.app.discussion
16 stars 47 forks source link

Apply validation for all captchas (version 3.4.x) #233

Closed ksuess closed 8 months ago

mister-roboto commented 8 months ago

@ksuess thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

ksuess commented 8 months ago

@jenkins-plone-org please run jobs

ksuess commented 8 months ago

@gforcada How do I proceed on this PR with the missing pre-commit.ci in 3.4.x branch?

ksuess commented 8 months ago

@mauritsvanrees , sorry, I've overseen a condition. May we get bug fix releases for version 3.4.x and 4.x please. Thank you and sorry for the noise.

mauritsvanrees commented 8 months ago

No problem. I have released 3.4.9 and 4.1.1 and have updated coredev.