search

plone / plone.app.discussion

General commenting system for Plone content
https://pypi.org/project/plone.app.discussion
16 stars 47 forks source link

Globally enable comments on install #244

Closed mauritsvanrees closed 2 months ago

mauritsvanrees commented 2 months ago

This is an afterthought of the just merged PLIP 3958.

In 6.1 you have to explicitly install the add-on in the Add-ons control panel. If you do that, then you obviously want discussions to be enabled globally. I think this also helps for the Volto case, where a Discussion control panel is missing, so in Plone 6.0 you cannot even properly enable comments.

Also, this gets rid of some test code that was only needed for ancient ATTopics. This is totally unrelated, I just happened to notice this while editing testing.py.

mister-roboto commented 2 months ago

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

mauritsvanrees commented 2 months ago

Several plone/meta tests are expected to fail because the current main branch has conflicts with released versions of other packages. That will be fixed once I release another 6.1 alpha.

mauritsvanrees commented 2 months ago

@jenkins-plone-org please run jobs

mauritsvanrees commented 2 months ago

Two plone.restapi tests fail: https://jenkins.plone.org/job/pull-request-6.1-3.10/311/

This needs a test fix in plone.restapi: https://github.com/plone/plone.restapi/pull/1805

mauritsvanrees commented 2 months ago

The Jenkins jobs pass. I merge.