search

plone / plone.app.iterate

Checkin/ checkout procedure for content editing (working copy) for Plone
https://pypi.python.org/pypi/plone.app.iterate
3 stars 12 forks source link

Plone6 styles #114

Closed spereverde closed 8 months ago

spereverde commented 1 year ago

Adding only the style changes from https://github.com/plone/plone.app.iterate/pull/96 Since @davisagli asked to seperate out the permission changes We'd love to have this update in in a next release since without it the statusmessages look pretty bad, or at least unstyled :-)

mister-roboto commented 1 year ago

@spereverde thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

spereverde commented 1 year ago

AT first sight it didn't seem that any of the permission changes were necessary for the style update, so I left all permission related commits form the plone6 branch out for now @pbauer, @davisagli let me know if that is wrong, I can cherry-pick the needed ones

gforcada commented 12 months ago

@spereverde you probably wanted to request a review from @pbauer rather from me :)

spereverde commented 12 months ago

@gforcada github suggested you, I guess because you made the last commits, I will add Philip as a reviewer, thx

davisagli commented 11 months ago

@spereverde I tested this. It's an improvement but the status message looks too wide:

Screenshot 2023-11-26 at 3 42 12 PM

Probably it needs to go inside a <div class="container">

spereverde commented 11 months ago

@davisagli I admit I didn't recheck visually on a clean setup, I'll amend a fix and let you know

laulaz commented 9 months ago

@davisagli I admit I didn't recheck visually on a clean setup, I'll amend a fix and let you know

Hey Kim ! are you still planning to work on this one ?

spereverde commented 9 months ago

@davisagli I admit I didn't recheck visually on a clean setup, I'll amend a fix and let you know

Hey Kim ! are you still planning to work on this one ?

apparently I forgot :-) I'd still like to work on this, but won't be able to the next 2 weeks, so feel free to take over if it's urgent for you

pbauer commented 8 months ago

I rebased the changes and wrapped the messages in a container

pbauer commented 8 months ago

@jenkins-plone-org please run jobs