search

plone / plone.app.iterate

Checkin/ checkout procedure for content editing (working copy) for Plone
https://pypi.python.org/pypi/plone.app.iterate
3 stars 12 forks source link

Use Plone 6.1 constraints in tox to avoid circular dependency error in Plone 6.0 #131

Closed wesleybl closed 3 weeks ago

wesleybl commented 1 month ago

See: https://github.com/plone/plone.formwidget.recaptcha/pull/37#discussion_r1790443757

mister-roboto commented 1 month ago

@wesleybl thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

wesleybl commented 1 month ago

@mauritsvanrees @gforcada even though I removed the circular job in .meta.toml it still ran. Did I do something wrong?

wesleybl commented 1 month ago

hum I need to run meta again after updating .meta.toml

davisagli commented 4 weeks ago

@wesleybl This PR targets the master branch, but Plone 6.0 uses the 5.x branch. This change shouldn't be needed for Plone 6.1, which does not have the circular dependency problem. Right?

wesleybl commented 3 weeks ago

@davisagli I changed the PR to use Plone 6.1 constraints, where the circular dependency problem does not exist.