search

plone / plone.app.ldap

Plone UI and integration of the functionality provided by LDAPMultiPlugins, LDAPUserFolder and PloneLDAP
3 stars 10 forks source link

PEP 8 #27

Closed hvelarde closed 8 years ago

jensens commented 9 years ago

is this still WIP? Or shall we merge?

hvelarde commented 9 years ago

WIP, but I'm busy at the moment

hvelarde commented 9 years ago

@jensens I saw you're already working on a Plone 5 branch and merging this will probably cause a bunch of headaches; I tried to separate every thing so we can probably cherry pick some commits while leaving others unmerged.

jensens commented 9 years ago

I just merged an already submitted PR with Plone 5 compat work

hvelarde commented 9 years ago

@jensens but you merge it on a different branch; how are we going to maintain this? I think is better to create a 1.x branch from master and then merge plone5 into master as 2.x.

then I can merge this into 1.x and start working on 2.x on the same.

jensens commented 9 years ago

having two branches for 4.3 and 5.0 sounds sane - but i'am not deep into this project, i just try to manage PR's

jensens commented 8 years ago

with plone 5 release and changes done in this package, this PR looks somewhat outdated. I close it, if different opinion please just reopen.