plone / plone.app.ldap

Plone UI and integration of the functionality provided by LDAPMultiPlugins, LDAPUserFolder and PloneLDAP
3 stars 10 forks source link

Imports are Python3 compatible #33

Closed ale-rt closed 6 years ago

coveralls commented 6 years ago

Coverage Status

Changes Unknown when pulling 6eabab4fff8a13bda1f3d00749e2fbfbc911bc73 on py3_imports into on master.

adaugherity commented 6 years ago

Why all the splitting of from foo import bar, baz into multiple imports? Unless there's some Python 3 import changes I'm unaware of, this isn't needed and buries the actual change of using six.StringIO.

I know Python 3 changed how relative imports work, but we're using absolute imports here. I just tested from setuptools import setup, find_packages in 3.6.1 and it works fine, no warnings... am I missing something?

ale-rt commented 6 years ago

@adaugherity it was done automatically by my editor that is configured to follow the plone coding guidelines: