search

plone / plone.app.linkintegrity

link integrity checking for Plone content
https://pypi.org/project/plone.app.linkintegrity
6 stars 9 forks source link

Report breaches once per item in delete_confirmation_info #95

Closed jaroel closed 11 months ago

jaroel commented 11 months ago

You'd get multiple entries for one page if there were multiple blocks w/ links on a page.

tisto commented 11 months ago

@jaroel would it be possible to group all breaches on a single page on the frontend? Or is this something that we need to take into consideration on the backend already?

jaroel commented 11 months ago

@tisto not a problem; looks like the screenshot in https://github.com/plone/volto/pull/5234 ;)

tisto commented 11 months ago

@jaroel @sneridagh we might have a problem here. p.a.linkintegrity dropped Plone 5.2 compatibility with version 4.0.0:

https://github.com/plone/plone.app.linkintegrity/blob/master/CHANGES.rst#400-2023-03-13

For FZJ we need Plone 5.2 support. This means we have to backport this feature to p.a.linkintegrity 3.x.x if I am not mistaken.

mauritsvanrees commented 11 months ago

It is too late in the evening, I can't wrap my brain around this change. Too many targets with sources and sources with targets. :-/

For FZJ we need Plone 5.2 support. This means we have to backport this feature to p.a.linkintegrity 3.x.x if I am not mistaken.

I would not call it a feature, but a bugfix. But we can disagree.

If we do not back port this, I expect you may get a few duplicates. That seems not so bad, but would be nice to fix. Or does Volto or restapi give an error when there are duplicates? That would make it more urgent.

tisto commented 11 months ago

@mauritsvanrees I am ok with it either way. I am also thorn between bugfix (technically correct) or feature (because it is nice to have it). Let's call it a bugfix then.

I'd expect Volto being able to work with both versions. We need to abstract away changes in "Plone core" either in plone.restapi or Volto. If we introduce a hard dependency on versions, this means lots of things to explain to people, which I would like to avoid.

I'd like to merge and backport this today then and do releases. @mauritsvanrees do you want to take care of this or shall I help out?

tisto commented 11 months ago

@jenkins-plone-org please run jobs

mauritsvanrees commented 11 months ago

I'd like to merge and backport this today then and do releases. @mauritsvanrees do you want to take care of this or shall I help out?

@tisto Go ahead.

tisto commented 11 months ago

@jaroel I did a release:

https://pypi.org/project/plone.app.linkintegrity/4.0.3/

Could you open another PR that backports this fix to 3.x.x?

tisto commented 11 months ago

@jaroel ok, you did this already. :)