search

plone / plone.app.mosaic

Plone Mosaic main repository
https://pypi.python.org/pypi/plone.app.mosaic
GNU General Public License v2.0
35 stars 26 forks source link

customized tinyMCE buttons on Rich Text tiles after update to 3.1.4 #582

Closed krissik closed 11 months ago

krissik commented 1 year ago

We have customized tinyMCE buttons for html tiles as described here

https://github.com/plone/plone.app.mosaic/blob/9a7df8a0bb25ff3a4a9da3fc818731f27c1349c8/docs/rich_text_buttons.rst

After Plone Update from 5.2 to 6.0.6 - and so updating plone.app.mosaic from 2.2.5 -> 3.1.4 - this is not working anymore. The buttons that are globally configured for tinyMCE (registry key: plone.toolbar) are shown on html tiles too.

Is this by intention, a bug or did I miss some new configuration?

petschki commented 1 year ago

This was mainly decided by me in order to generalize the usage of TinyMCE control panel also for mosaic toolbar. But working a while with this I'm now convinced, that a separate toolbar config for mosaic editor makes sense.

/cc @frapell

frapell commented 1 year ago

@petschki Yeah, I agree... is this change easily reverted?

petschki commented 11 months ago

I've refactored and implemented the toolbar customization again. Since we're reusing pat-tinymce now we can simply override the tiny pattern config in the widget code. See https://github.com/plone/plone.app.mosaic/pull/584/commits/5a7bce9ecba1b746708bf51090bf42da82d0493e ... the rest of the PR is maintenance...

petschki commented 11 months ago

Fixed and released in 3.1.5