search

plone / plone.app.mosaic

Plone Mosaic main repository
https://pypi.python.org/pypi/plone.app.mosaic
GNU General Public License v2.0
34 stars 26 forks source link

fix activating toolbar buttons via keyboard #588

Closed Nimo-19 closed 7 months ago

Nimo-19 commented 7 months ago

by switching from mousedown to click event

mister-roboto commented 7 months ago

Jonathan Hofmann your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement How to add more emails to your GitHub account: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account

petschki commented 7 months ago

Hi, would you mind keep the actual code change and the compiling change in a separate commit? then the PRs get more readable.

petschki commented 7 months ago

Not sure what this change actually want's to fix. I do not see any difference in keyboard handling when using this event. But nevertheless I've taken your change in my current bugfix and cleanup session as I think, mousedown is not the right event to listen tol. So I'll close this in favor #589 (Plone 6.1) and #590 (Plone 6.0) ... review welcome.