search

plone / plone.app.multilingual

Plone Multilingual Content Add-on
https://pypi.org/project/plone.app.multilingual
19 stars 47 forks source link

fix language switcher at installation #376

Closed marclava closed 3 years ago

mister-roboto commented 4 years ago

@marclava you need to sign the Plone Contributor Agreement in order to merge this pull request.

Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

mister-roboto commented 4 years ago

@marclava thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

jensens commented 4 years ago

Thanks for your contribution!

May you elaborate why this is needed? Usually the value is already a tuple. And a tuple + a tuple is a tuple again. 

>>> foo = (1,2,3)
>>> foo + (4,)
(1, 2, 3, 4)
mliebischer commented 3 years ago

The issue should be fixed in version 5.6.3 of plone.app.multilingual, see Merge Request https://github.com/plone/plone.app.multilingual/pull/341 for details.